Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate topic for lifecycle transition tasks #2468

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Use separate topic for lifecycle transition tasks #2468

merged 2 commits into from
Nov 15, 2023

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Nov 7, 2023 •
edited
Loading

The lifecycle conductor uses the lag on the object tasks to throttle the lifecycle scan.
However, the object tasks topic handles events that are not in the direct path and that does not impact the lifecycle scan.
We use a different topic for those events to avoid unwanted throttle.

Issue: BB-467

@bert-e
Copy link
Contributor

bert-e commented Nov 7, 2023

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@scality scality deleted a comment from bert-e Nov 7, 2023
@bert-e
Copy link
Contributor

bert-e commented Nov 7, 2023

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@Kerkesni Kerkesni force-pushed the bugfix/BB-467-separate-transition-topic branch 3 times, most recently from f22e465 to 231e961 Compare November 8, 2023 13:38
@Kerkesni Kerkesni force-pushed the bugfix/BB-467-separate-transition-topic branch from 231e961 to cc04807 Compare November 9, 2023 13:07
@Kerkesni Kerkesni force-pushed the bugfix/BB-467-separate-transition-topic branch from cc04807 to a2826dd Compare November 9, 2023 14:36
@Kerkesni Kerkesni force-pushed the bugfix/BB-467-separate-transition-topic branch from a2826dd to ae4bab3 Compare November 9, 2023 15:22
@Kerkesni
use separate topic for lifecycle transition tasks
1cf41cc 
The lifecycle conductor uses the lag on the object tasks topic to throttle the lifecycle scan.
However, the object tasks topic handles events that are not in the direct path and that
does not impact the lifecycle scan.
We use a different topic for those events to avoid unwanted throttle.

Issue: BB-467
@Kerkesni Kerkesni force-pushed the bugfix/BB-467-separate-transition-topic branch from ae4bab3 to 6859311 Compare November 9, 2023 15:22
KillianG
KillianG approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@KillianG KillianG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 little comment about phrasing the tests

@Kerkesni Kerkesni force-pushed the bugfix/BB-467-separate-transition-topic branch from 6859311 to c8564d2 Compare November 14, 2023 10:33
@Kerkesni
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 14, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@scality scality deleted a comment from bert-e Nov 15, 2023
@bert-e
Copy link
Contributor

bert-e commented Nov 15, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 15, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

Please check the status of the associated issue BB-467.

Goodbye kerkesni.

@bert-e bert-e merged commit c8564d2 into development/8.6 Nov 15, 2023
7 checks passed
@bert-e bert-e deleted the bugfix/BB-467-separate-transition-topic branch November 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KillianG KillianG KillianG approved these changes

@francoisferrand francoisferrand francoisferrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kerkesni @bert-e @francoisferrand @KillianG